emdneto

Cool. I was implementing this and just saw your PR today. @herin049 wdyt to instead use the concept of a NoOpExporterMetrics? This way, we also avoid creating the instruments.

Something like:

class NoOpExporterMetrics:
    @contextmanager
    def export_operation(self, num_items: int) -> Iterator[ExportResult]:
        yield ExportResult()

And from a factory, you check the env var

def create_exporter_metrics(signal, endpoint, meter_provider):
    if not parse_boolean_environment_variable(
        OTEL_PYTHON_SDK_INTERNAL_METRICS_ENABLED,
        default=False,
    ):
        return NoOpExporterMetrics()

    return ExporterMetrics(signal, endpoint, meter_provider)

I'm ok with the env var name 👍🏻

Updated the PR based on the suggestions. I opted to keep environment variable parsing outside of the factory method to keep configuration separate from construction (and to prevent having to add opentelemetry-sdk to the proto package).